Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotw fixing #3101

Merged
merged 3 commits into from
May 13, 2024
Merged

Lotw fixing #3101

merged 3 commits into from
May 13, 2024

Conversation

phl0
Copy link
Contributor

@phl0 phl0 commented May 13, 2024

This fixes a few things in LoTW uploads:

  • The OpenSSL base64 data normally needs a newline at the end to be able to verify signatures correctly. This has been worked around on LoTW side but probably be good to be compliant in the first place
  • The upload filename has the full path stripped. Not really an issue but just in case ... It does not harm to hide the directory structure of the uploading system
  • The unsafe cURL file upload has been removed from PHP. So this part of the code should be removed as well as PHP fails with an error because the insecure method is not allowed any more.

@magicbug
Copy link
Owner

Thanks Flo agreed should be addressed

@magicbug magicbug merged commit 314c42e into magicbug:dev May 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants